praiskup / argparse-manpage

Automatically build man-pages for your Python project
Apache License 2.0
40 stars 21 forks source link

Add support for pre-written man pages (manfile option) #89

Closed rrthomas closed 1 year ago

rrthomas commented 1 year ago

This PR fixes #88.

rrthomas commented 1 year ago

My test is failing just in Copr. The pre-written man page file is not found by the install function, for some reason; it looks like it's not being copied into the egg.

praiskup commented 1 year ago

Sorry, this has been a busy week so far; thank you for the PR, I'm going to review ASAP!

rrthomas commented 1 year ago

Thanks, and of course, no problem; you will have spotted I have made another PR in any case (to support pre-written man pages); these two PRs are my "must-haves", i.e. things that I need in a release of argparse-manpage in order to make releases of my own software. After that I hope I will find time to fix the other issues I have filed, but they are only "nice-to-haves".

praiskup commented 1 year ago

Try

diff --git a/MANIFEST.in b/MANIFEST.in
index 0641bad..5380b30 100644
--- a/MANIFEST.in
+++ b/MANIFEST.in
@@ -11,6 +11,7 @@ include examples/resalloc/expected/man/resalloc.1
 include examples/copr/fake-deps/HACK
 include examples/copr/fake-deps/copr/README
 include examples/raw-description/bin/dg
+include examples/pre-written-man-page/psutils.1
 include examples/resalloc/bin/resalloc
 include examples/resalloc/bin/resalloc-maint
 include tests/extra.man
rrthomas commented 1 year ago

Try

diff --git a/MANIFEST.in b/MANIFEST.in
index 0641bad..5380b30 100644
--- a/MANIFEST.in
+++ b/MANIFEST.in
@@ -11,6 +11,7 @@ include examples/resalloc/expected/man/resalloc.1
 include examples/copr/fake-deps/HACK
 include examples/copr/fake-deps/copr/README
 include examples/raw-description/bin/dg
+include examples/pre-written-man-page/psutils.1
 include examples/resalloc/bin/resalloc
 include examples/resalloc/bin/resalloc-maint
 include tests/extra.man

Done, thanks!