agent-spawner: base64 encode the resalloc ticket DATA in env

praiskup / resalloc

Allocator and manager for (expensive) resources

GNU General Public License v2.0

7 stars 7 forks source link

agent-spawner: base64 encode the resalloc ticket DATA in env #145

Closed praiskup closed 8 months ago

praiskup commented 8 months ago

Fixes: #144

siteshwar commented 8 months ago

I have not tested these changes, but here are some general observations:

Where is this variable named RESALLOC_RESOURCE_DATA?
Where are RESOURCE_NAME, RESOURCE_POOL_ID etc. are set?
Why RESALLOC_RESOURCE_DATA has to be base64 encoded? Is that because terminal output may contain binary characters?

praiskup commented 8 months ago

These are set here: https://github.com/praiskup/resalloc/blob/36a289d6e050c88dd5451dec9d838afa7779cbbb/resallocserver/manager.py#L40-L50

Is that because terminal output may contain binary characters?

Yes.

siteshwar commented 8 months ago

These are set here:

Why they are not visible in the env output?

praiskup commented 8 months ago

They are actually. But resalloc != agent spawner.

siteshwar commented 8 months ago

They are actually. But resalloc != agent spawner.

Is this comment valid for agent spawner? If not, it should be removed and we should mention AGENT_SPAWNER_RESOURCE_DATA instead.

praiskup commented 8 months ago

Thank you for patiently punching me. You are right; the comment was wrong. I updated the docs, and fixed the fix.

Can you please take another look now?

siteshwar commented 8 months ago

Thank you for patiently punching me. You are right; the comment was wrong. I updated the docs, and fixed the fix.

Can you please take another look now?

LGTM. Although I have not tested these changes.