[Android Bootcamp] Day 2 assignment

[prajaa]

My app is ready , please review. /cc @codepathreview @codepath. Name: Prajakta Link to Video - https://github.com/prajaa/MyInstagramClient/blob/master/app/src/main/res/drawable/day2.gif

Covers user stories -

1. Connect the app with the Instagram API and get real time data using async-http-client library.
2. Show the last 2 comments for each photo.
3. User can view all comments for a post within a separate activity.
4. User can share an image to their friends or email to themselves.

Optional user story covered

5. Robust error handling, check if internet is available, handle network failures.

Time taken - 8 hours

[codepathreview]

Great work finishing the stories. Here is some feedback after reviewing your code --

• Good job initializing Fresco in Application's onCreate method
• Good job refactoring Activity's onCreate method into helper methods such as initUi(). This keeps lifecycle methods clean and increases readability, specially as your Activity increases in complexity
• It's preferred that a convenience method be created on the adapter to reload content. This helps DRY up code and encapsulate adapter behavior if the Activity needs to call this several times in different places.
• Good job setting OnClickListener instances in ViewHolder constructor rather than RecyclerView.Adapter.onBindViewHolder()
• Good job setting up InstagramClient such that every endpoint is represented with a method which then accepts specific parameters and a “handler”
• Good job handling the network error case by overriding onFailure and notifying the user