[Android Bootcamp] Day 3 Assignment

[prajaa]

My app is ready , please review. /cc @codepathreview @codepath. Name: Prajakta Link to Video - https://github.com/prajaa/MyInstagramClient/blob/master/app/src/main/res/drawable/day3.gif

Covers user stories User can login to Instagram using OAuth login. User can view their own feed. User can search for a user by username. User can search for a tag. On the search screen, there will now be 2 tabs corresponding to "USERS" and "TAGS". When performing a search, the user can switch between the "USERS" tab and the "TAGS" tab and see search results for each one.

Optional items were not completed. Will complete them soon

[codepathreview]

Good job finishing all the stories. Some feedback after looking at the code -

• It is a better way to have a global helper method to retrieve the InstagramClient in Application class
• Good job doing any assignment of subviews to fields in onViewCreated. This is because the framework does an automatic null check for you to ensure that your Fragment's view hierarchy has been created and inflated (if using an XML layout file) properly.
• Updating the adapter should be done by calling notifyDataSetChanged instead of creating a new adapter after fetching completes
• It's always a good idea to display an indeterminate or determinate progress bar to the user when potentially long running tasks are happening in the background, especially those that update views. See this guide on implementing a ProgressBarView.
• It is recommended to put integer dimension, sp, dp etc to 'dimens.xml'