codepathreview
commented
9 years ago Good job finishing all the stories. Read through this point-by-point to determine how you could improve your submission.
- How to handle the Home button click?
- Best way to handle home button is not through onOptionsItemSelected or onKeyDown. If you want to handle anything during home pressed, you should do so in onPause.
- How to improve upon initializing view?
- Start using
ViewInjectionto inject views and you can get rid of a lot of boilerplate code. One of the popular libraries for ViewInjection is Butterknife
- Start using
- How to better handle network request failures?
- Always make sure to override onFailure, log appropriate information that can be helpful in debugging too and make sure to clear out progress indicator if set
- Parcelable vs Serializable
- Implement Parcelable instead of Serializable in all models for performance reasons
My app is ready , please review. /cc @codepathreview @codepath. Name: Prajakta Link to Video - https://github.com/prajaa/MyInstagramClient/blob/master/app/src/main/res/drawable/day5.gif
Issue Faced : On clicking the User Profile Image on the Posts Fragment, I struggled a little to invoke the Profile Fragment for the user. Mostly regarding invoking a fragment from the ViewHolder onclick. In the PostsAdapter.PostViewHolder -> When I did the fts.replace, Initially i tried replacing the viewPager with the fragment which did not work, but later I tried replacing the container layout, that worked. But still in the new UI, I messed up my tabs and they were moved to the top instead of being at bottom. Please can you specify a better way of handling this.
User Stories Covered : 1) Add the Profile Page to your TabLayout to see your own posts, follower count, following count. 2) Add the ability to see a your photos below the profile information 3) Clicking on any user's profile image goes to that user's profile page. 4) Replace the ActionBar with a ToolBar and style it to match the actual Instagram app. 5) Add infinite scroll to your home feed.