search

prajjwaldimri / GithubXamarin

GithubXamarin(GitIt) is a cross-platform application for https://github.com which is built using Xamarin.
GNU General Public License v3.0
981 stars 22 forks source link

Text is missing from events #88

Closed cristianst85 closed 7 years ago

cristianst85 commented 7 years ago

Hi,

I've attached two screenshots that shows this bug. In this case probably the culprit is that the original text contains an emoticon.

GitHub events as shown in browser github-events

GitHub events as shown by GitIt wp_ss_20170504_0005

Also, the time is off by one hour (my timezone is EEST - Eastern European Summer Time / UTC+3).

Thanks!

prajjwaldimri commented 7 years ago

Hmm, this seems weird. The top comment and the 3rd comment are basically the same thing and one is getting displayed and other is not. :thinking: Have to take a look into this.

Meanwhile, if anyone wants to take a look into this, the string for this type of event is supplied from here: https://github.com/prajjwaldimri/GithubXamarin/blob/master/GithubXamarin.Core/Converters/EventToStringConverter.cs#L40

Relevant github api link: https://developer.github.com/v3/activity/events/types/#issuecommentevent

Also about the timezone, it is provided by github api directly and the app is not doing any time conversions, so could be a problem with system time.