Quick comments - Githubissues

prajogt / ttc_analysis

An analysis of the delays plaguing the TTC

MIT License

0 stars 1 forks source link

Quick comments #1

Open mpejcinovska opened 7 months ago

mpejcinovska commented 7 months ago

From a glance the submission seems solid.

A few quick comments/suggestions for final paper:

At the moment, it seems as though Table 1 and 2 are conflated for the two datasets. You might want to clear this up.
I would suggest making the plots slightly bigger for readability (this includes playing with size of axis text)
The paper could benefit from a more thorough discussion of your findings!

prajogt commented 7 months ago

@mpejcinovska thanks for the comments.

What does your first comment on "conflated" mean. By the definition it means that they are merged? However I don't believe this to be the case. If you mean that they should be merged, I'm not sure the reason as that should be since for the visualization and analysis I would have to unmerge them (whether implicitly within ggplot's specification or explicitly).

mpejcinovska commented 7 months ago

Oh! Sorry if that wasn't clear. I'm using it to indicate "mixed up" not merged. This may have been a lack of understanding on my part, but from a quick read, it felt like you should have been talking about variables in the two date sets (bus and subway) but you were actually talking about the variables as part of the two tables. Since the things you are describing are essentially features of the data (the variables in the data), it might be better to not talk about them as features of the tables but rather of the data. Does this help get my point across?

prajogt commented 7 months ago

Ah I see thanks for clarifying! That makes sense.