search

prajwalrao / ambari-metrics-grafana

Ambari Metrics System Plugin for Grafana > v4.5.x
https://grafana.net/plugins/praj-ams-datasource
Other
25 stars 37 forks source link

changes to Ambari datasource so that there is no dependency on the de… #2

Open mhollick opened 8 years ago

mhollick commented 8 years ago

…fault datasource not already having been assigned.

prajwalrao commented 8 years ago

@mhollick Thanks for the PR, but I do have a question. Why would you hardcode a datasource into the dashboards? The reason it wasn't done so from the get-go was so that the user could use any datasource name and it would work as long as it is the default datasource.

mhollick commented 8 years ago

Hi, maybe I misunderstand how datasources should be used.

I already have a few datasources configured. One of them is set to the default and I have a few dashboards referencing it not by name but as the default. When I import your dashboards I have the choice of either changing my dashboards to reference a datasource by name, or yours. My feeling is that best practice should be for no dashboard to ever reference the default datasource. I'm happy to be proven wrong.

While I am here, I noticed that a couple or so of your dashboards present rate data as counters. I will let you know which ones / raise a pull request when I have the time to go through them.

Thanks loads for this Grafana plugin - it's a real life saver for us.