search

prakashlab / octopi-driver-board

Driver electronics for the Octopi and Squid microscope families.
https://squid-imaging.org/
Other
6 stars 5 forks source link

Add basic unit tests for PP-T41 #19

Closed ethanjli closed 3 years ago

ethanjli commented 3 years ago

This PR provides new unit tests for the Octopi Driver Stack:

More information about these tests are available in the README.md files for these tests.

Open-Source Records-Keeping

After final changes are made on this PR and it is approved for merging, I will answer the following questions as a new comment on this PR, for records-keeping:

  1. This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? {CHOOSE YES OR NO}
  2. Were any of these contributions also part of work you did for an employer or a client? If so, do you have their permission to release it? {CHOOSE YES OR NO FOR THE FIRST QUESTION, AND CHOOSE YES, N/A, OR PROVIDE AN EXPLANATION TO THE SECOND QUESTION}
  3. Does this work include, or is it based on, any third-party work which you did not create? If so, what is it licensed under, and what modifications, if any, did you make to it? {CHOOSE YES OR NO, AND EXPLAIN. FOR EXAMPLE, A GOOD EXPLANATION FOR INCLUSION OF THIRD-PARTY PARTS WOULD BE: third-party documentation, CAD models, PCB footprints of parts have been included in the Parts directory. I have added appropriate notices for these files in the README.md files in the corresponding directories.}
ethanjli commented 3 years ago

For records-keeping:

  1. This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes
  2. Were any of these contributions also part of work you did for an employer or a client? If so, do you have their permission to release it? Yes, N/A
  3. Does this work include, or is it based on, any third-party work which you did not create? If so, what is it licensed under, and what modifications, if any, did you make to it? Yes: unit tests which are Arduino sketches depend on the Arduino/Teensyduino cores, which are licensed under LGPL.
ethanjli commented 3 years ago

Because further tests cannot be verified until after #17 is fixed (and even PP-T41_DSCS_Demux can only be partially verified before #17 is fixed), I will merge in this PR now, even though it only partially addresses #12 in its current state.