prakhar1989 / dive-in

A docker extension to help you explore a docker image and discover ways to shrink the size
37 stars 11 forks source link

Installation Fails #6

Closed phoward38 closed 1 year ago

phoward38 commented 1 year ago

When attempting to install from either Docker Desktop or Docker Hub, an error message is thrown:

Dive was not found. Click the button below to install Dive

However, clicking the button doesn't resolve the issue, nor does manually installing dive CLI. I'm using Docker Desktop v4.15.0 on MacOS (M1) v12.6.2.

krankkkk commented 1 year ago

For anyone having this issue, clear out your local image cache and try again. For me it was an issue with an image that has no tags, resulting in App.tsx line 48 failing exceptionally because i.RepoTags is null/undefined.

Also the plugin doesn't seem to use the local installation, but rather pulls the required docker image and uses that instead. So having dive installed it locally makes no difference for this plugin.

phoward38 commented 1 year ago

@krankkkk I appreciate the workaround, but unfortunately clearing out my local image cache simply to install an extension isn't an option for me at the moment (we're setting up CI/CD to build our images with external services, but at the moment I rely on that cache for a number of long running builds).

Ideally, the code you pointed out where the error occurs would account for older images without tags if there is a newer version with any sort of tag (manual or latest).

@prakhar1989 Any thoughts on this? I've only glanced at the chunk of code that @krankkkk pointed out & it seems like a fairly minor fix, but I'm curious if you ran into any issues regarding this while creating the extension.

flcdrg commented 1 year ago

I can confirm that removing an image that was untagged (it had been superceded by a newer image) worked.

jrobertson-insite commented 1 year ago

Clearing the cache is not a valid fix/workaround. Hopefully this is fixed, I'd like to be able to use the dive-in extension.

murlakatam commented 1 year ago

For me it was fixed by clearing all untagged images

docker images -f dangling=true

then if any

docker images -qf dangling=true | xargs docker rmi -f

And then pulling

docker pull prakhar1989/dive-in
docker pull prakhar1989/dive

what's the difference between those 2?

phoward38 commented 1 year ago

@prakhar1989 Thanks for merging #7. An update here when it's been updated on the Docker Desktop Extension Marketplace would be great. Thanks!

prakhar1989 commented 1 year ago

Updated docker hub: https://hub.docker.com/layers/prakhar1989/dive-in/0.0.8/images/sha256-0adcd44cc1cfcd4a6bdd85f0da02c69aa1603f4a85ce8d8f255e23d38cce8e25?context=explore

phoward38 commented 1 year ago

@prakhar1989 Thanks, but unfortunately the newest version still throws the same error message