db-based-generation has the wrong identifier for context end

prakharguptaz / Instructdial

Code for the paper Code for the paper InstructDial: Improving Zero and Few-shot Generalization in Dialogue through Instruction Tuning

Apache License 2.0

96 stars 13 forks source link

db-based-generation has the wrong identifier for context end #14

Closed cuthalionn closed 1 year ago

cuthalionn commented 1 year ago

Hi,

Please correct me if I am wrong but I believe the context end identifier for db-based-generation task is wrong. It should be: settings.EOD_SEP rather than settings.EOT_SEP

https://github.com/prakharguptaz/Instructdial/blob/046de5c9a70d8791b6db8514f23fbfc50a3174c2/instruction_files/db_based_generation.py#L109

prakharguptaz commented 1 year ago

Thanks for pointing this out. Fixed