prakhartiwari0 / arito

Arito is an Open-Source WebApp for practicing arithmetic skills.
https://myarito.xyz
MIT License
101 stars 88 forks source link

[BUG] Accepting 0 as the Number of Questions in the Input #213

Open Ishita-Ghosh-25 opened 1 year ago

Ishita-Ghosh-25 commented 1 year ago

Describe the bug If zero is entered in the Number of Questions, the app should prompt the user to fill in something between 1 to 55 To Reproduce Steps to reproduce the behavior:

  1. Go to 'Home Page'
  2. Click on 'Let's Start'
  3. Scroll down to 'No. of Questions (below 56)'
  4. Give input as '0'
  5. See an error that is not prompting to input a number greater than zero

Expected behavior Should prompt the user to input any number between the range of 1 to 56

Screenshots

image

Question 1/0 is mentioned under addition which should not happen

image

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

github-actions[bot] commented 1 year ago

Thanks for raising this issue & giving your bit in this project's development 😇

gambhirsharma commented 1 year ago

@Ishita-Ghosh-25 I have assigned this issue to you.

Are you making this contribution under GSSOC23?

shrish-01 commented 10 months ago

@Ishita-Ghosh-25 I have assigned this issue to you.

Are you making this contribution under GSSOC23?

I see, this issue is open. Would like to fix this. Can this be assigned to me please?