search

pramoth / specification-with-projection

Support projections with JpaSpecificationExecutor.findAll(Specification,Pageable) for Spring Data JPA
MIT License
164 stars 56 forks source link

Implementation Reccommendation #5

Closed dengizik closed 6 years ago

dengizik commented 6 years ago

I have one reccommendation:

Having below implementation makes also sense for me:

Page findAll(Specification var1, Class var2) What do you think?
pramoth commented 6 years ago

If not specify PageRequest then a return page maybe huge page. so I think we need PageRequest in all case.