search

prampec / IotWebConf

ESP8266/ESP32 non-blocking WiFi/AP web configuration Arduino library
MIT License
523 stars 140 forks source link

Add mDNS update to main loop for ESP8266 #253

Closed shmick closed 2 years ago

shmick commented 2 years ago

On ESP8266 it needs MDNS.update() to run in the main loop

prampec commented 2 years ago

As far as I see, the update must be called as frequently as possible in ESP8266. https://github.com/esp8266/Arduino/blob/master/libraries/ESP8266mDNS/src/LEAmDNS.h

So it should be placed inside the doLoop() method. (Must be tested before I approve!)

shmick commented 2 years ago

So it should be placed inside the doLoop() method. (Must be tested before I approve!)

My code update does place it inside doLoop() inside of the else if (this->_state == OnLine statement

I can confirm that it's working from my own local testing. Always best to have others test as well.

prampec commented 2 years ago

Sorry, I have missed something.

prampec commented 2 years ago

Thank you for your contribution.