pramsey / pgsql-ogr-fdw

PostgreSQL foreign data wrapper for OGR
MIT License
237 stars 34 forks source link

installcheck failure: ERROR: invalid input syntax for type date: "22090-160-00" #133

Closed df7cb closed 7 years ago

df7cb commented 7 years ago

Hi, I'm seeing installcheck failures with 1.0.3 on Debian/unstable against PostgreSQL 9.6:

**** regression.diffs ****
*** /tmp/autopkgtest.uwHrqV/tree/expected/pgsql.out 2017-10-03 12:16:33.408523726 +0200
--- /tmp/autopkgtest.uwHrqV/tree/results/pgsql.out  2017-10-03 12:16:34.600528534 +0200
***************
*** 41,64 ****
    yn char
  ) SERVER pgserver OPTIONS (layer 'bytea_local');
  SELECT fid, name, geom, age, size, value, num, dt, tm, dttm, varch, yn FROM bytea_fdw;
!  fid |  name  |     geom     | age | size | value |  num  |     dt     |    tm    |           dttm           |  varch   | yn 
! -----+--------+--------------+-----+------+-------+-------+------------+----------+--------------------------+----------+----
!    1 | Jim    | \x3134323332 |  23 |    1 |   4.3 |  5.50 | 10-10-2010 | 13:23:21 | Sun Oct 10 13:23:21 2010 | this     | y
!    2 | Marvin | \x3535353535 |  34 |    2 |   5.4 | 10.13 | 11-11-2011 | 15:21:45 | Fri Nov 11 15:21:45 2011 | that     | n
!    3 |        |              |     |      |       |       |            |          |                          |          | 
! (3 rows)
! 
  SELECT a.name, b.name 
    FROM bytea_local a 
    JOIN bytea_fdw b 
    USING (fid);
!   name  |  name  
! --------+--------
!  Jim    | Jim
!  Marvin | Marvin
!         | 
! (3 rows)
! 
  EXPLAIN VERBOSE 
    SELECT fid, name, geom, age, size, value, num, dt, tm, dttm, varch, yn
    FROM bytea_fdw;
--- 41,52 ----
    yn char
  ) SERVER pgserver OPTIONS (layer 'bytea_local');
  SELECT fid, name, geom, age, size, value, num, dt, tm, dttm, varch, yn FROM bytea_fdw;
! ERROR:  invalid input syntax for type date: "22090-160-00"
  SELECT a.name, b.name 
    FROM bytea_local a 
    JOIN bytea_fdw b 
    USING (fid);
! ERROR:  invalid input syntax for type date: "22090-160-00"
  EXPLAIN VERBOSE 
    SELECT fid, name, geom, age, size, value, num, dt, tm, dttm, varch, yn
    FROM bytea_fdw;
***************
*** 114,124 ****
    FROM bytea_local a 
    JOIN bytea_fdw b 
    USING (fid);
!  fid |  name  |  name  
! -----+--------+--------
!    1 | Jim    | Jim
!    2 | Marvin | Marvin
!    3 |        | 
! (3 rows)
! 

--- 102,106 ----
    FROM bytea_local a 
    JOIN bytea_fdw b 
    USING (fid);
! ERROR:  invalid input syntax for type date: "22090-160-00"

1.0.2 was fine.

pramsey commented 7 years ago

Ah, I have it too. And I have an explanation: seems to be an issue that GDAL 2.2 introduces, and that's what I have in my machine (and probably you do too) but travis only tests up to 2.1, hence the clean badge. It's NULL handling.

df7cb commented 7 years ago

Thanks!