search

pramsey / pgsql-ogr-fdw

PostgreSQL foreign data wrapper for OGR
MIT License
237 stars 34 forks source link

PostgreSQL 12 support #160 #161

Closed robe2 closed 5 years ago

robe2 commented 5 years ago

These are changes I made to support 12 (head as of a couple of days ago).

1) I tested against 10,11,12 (note that I don't build GDAL with postgres support, so that test always fails for me, but the other tests pass on all 3 platforms).

2) I am also not absolutely sure we should remove optimizer/cost.h as I think it worked when I kept it in, but I was just following adunstan in that he removed that one as well, so assumed it's probably not needed for 12.

3) I'm not absolutely sure T_ParamRef is a replacement for T_ArrayRef, but T_ArrayRef definitely no longer exists in 12, and I just followed the compiler suggestion which worked (don't recall in place the compiler giving "Did you mean hints" . I suspect that code is not exercised in the tests and not sure which data set I could use to exercise it.

4) Sorry for the unrelated whitespace changes -- those I presume are triggered by .editorconfig you put in place.

robe2 commented 5 years ago

RhodiumToad in IRC suggested T_SubscriptingRef for replacement of T_ArrayRef. I'm going to check that out and provide an updated pull request