pramsey / pgsql-ogr-fdw

PostgreSQL foreign data wrapper for OGR
MIT License
239 stars 34 forks source link

PG17 compile error and add PG17 ci #255

Closed robe2 closed 7 months ago

robe2 commented 7 months ago

I was gearing to add a PG17 cause well stuff is breaking in postgis, so figure stuff might be breaking here too and voila, we have an issue

https://github.com/robe2/pgsql-ogr-fdw/actions/runs/8444294542/job/23129550923

Run export PATH=/usr/lib/postgresql/17/bin/:$PATH
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -g -g -O2 -flto=auto -ffat-lto-objects -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -fno-omit-frame-pointer -Werror -fPIC -fvisibility=hidden -I/usr/include/gdal -I. -I./ -I/usr/include/postgresql/17/server -I/usr/include/postgresql/internal  -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -I/usr/include/libxml2   -c -o ogr_fdw.o ogr_fdw.c
ogr_fdw.c: In function ‘ogrGetForeignPaths’:
ogr_fdw.c:947:26: error: too few arguments to function ‘create_foreignscan_path’
  947 |                  (Path*) create_foreignscan_path(root, baserel,
      |                          ^~~~~~~~~~~~~~~~~~~~~~~
In file included from ogr_fdw.h:45,
                 from ogr_fdw.c:40:
/usr/include/postgresql/17/server/optimizer/pathnode.h:125:21: note: declared here
  125 | extern ForeignPath *create_foreignscan_path(PlannerInfo *root, RelOptInfo *rel,
      |                     ^~~~~~~~~~~~~~~~~~~~~~~
make: *** [<builtin>: ogr_fdw.o] Error 1
robe2 commented 7 months ago

I'll work on a patch for this and include as part of the ci 17 addition.