Command Refactor - Githubissues

pranavbhuv / CastleRaid-Core

5 stars 5 forks source link

Command Refactor #31

Closed iiFlamiinBlaze closed 6 years ago

iiFlamiinBlaze commented 6 years ago

Changes:

[x] Fixing formatting for command files
[x] Adding BaseCommand
[x] Fixing player checks
[x] Fixing permission checks
[x] Removing useless else statements
[x] Moving command files and fixing organization
[x] Moving constants around from API
[ ] Add utils, maybe? @Teamblocket

unickorn commented 6 years ago

@iiFlamiinBlaze does changes they dont work undoes changes tries something else still doesn't work finally fixes part of it, says fixed That's not what I meant by "test your code before committing"! Please don't merge this.

iiFlamiinBlaze commented 6 years ago

The only things that I don't test are conflicts, and idrk how to fix them correctly since I don't have git. Please look at the commit before commenting, thanks.

BaseCommand and changes to command files work fine, it is just the conflicts that are not.