pranavgupta1234 / rqmonitor

Flask based more dynamic and actionable frontend dashboard for monitoring Redis Queue 👩🏿‍💻 http://python-rq.org
Apache License 2.0
186 stars 24 forks source link

Fix exception when worker hostname is not defined #12

Closed oriolpiera closed 3 years ago

oriolpiera commented 3 years ago

Previous

When a Worker has not defined the attribute hostname, it raise an exception and the list of workers is not showed

image

After

The list of Workers appears and the field hostname in workers without this attributed, is showed blank

image

pranavgupta1234 commented 3 years ago

I think it would be better to show this case also as "Unresolved" (although its not exactly similar to case when IP is not resolved from given hostname) but showing two behaviour like leaving blank and showing unresolved might be confusing.

oriolpiera commented 3 years ago

That works for me