search

pranavgupta1234 / rqmonitor

Flask based more dynamic and actionable frontend dashboard for monitoring Redis Queue 👩🏿‍💻 http://python-rq.org
Apache License 2.0
186 stars 24 forks source link

Search in the Job List Panel Not Working #21

Open rednafi opened 3 years ago

rednafi commented 3 years ago

Hi. Thank you for your amazing work. Really loving it over the de-facto rq monitor.

While trying to integrate it in an application, I discovered that the search bar in the job list panel doesn't do anything. It works fine on the worker list panel. Here's a screenshot of it working in the worker list panel:

Screenshot from 2021-07-23 06-47-39

Here's a list of it not working as expected in the job list panel:

Screenshot from 2021-07-23 06-48-07

The console doesn't raise any errors. It'd be helpful if we could search the jobs by their names here.

pranavgupta1234 commented 3 years ago

The reason you are able to search in workers is because the one being searched is already available on client side. Currently only client side searching is implemented for all tables so the items fetched in current pagination are being searched from. The reason I skipped for server side searching for jobs was due to performance reasons via available rq API, will have to look an efficient way to do that search in redis.

rednafi commented 3 years ago

Interesting. Yeah, the reason is clear to me. However, this is pretty important for a monitor as it enables you quickly look for the stacktrace of a failed job and take appropriate actions. Celery Flower also has something like this. Maybe in the upcoming version. Thank you 😄

andrew-oreshko commented 2 years ago

@pranavgupta1234 are you by chance planning to implement this feature anytime soon?

pranavgupta1234 commented 2 years ago

@andrew-oreshko cannot make any commitments right now but thinking to pick it up in Jan-Feb 2022.