search

pranavgupta1234 / rqmonitor

Flask based more dynamic and actionable frontend dashboard for monitoring Redis Queue 👩🏿‍💻 http://python-rq.org
Apache License 2.0
186 stars 24 forks source link

Usage of Python 3.8 in Dockerfile #6

Closed trodery closed 4 years ago

trodery commented 4 years ago

Hi there,

Firstly, you've done a fantastic job with your project! You've addressed a lot of the shortcomings of rq-dashboard.

Secondly, I've run into an issue when fetching jobs where the job data was pickled with Python 3.8. The job data pickle is protocol 5, which isn't present in Python 3.7. The exception I receive in the console when fetching jobs is below:

rq.exceptions.UnpickleError: ('Could not unpickle', ValueError('unsupported pickle protocol: 5'))

I've noticed your Dockerfile is using python:3.7-slim though setup.py specifies compatibility with Python 3.8. Any reason why a switch to python:3.8-slim couldn't be made? I'm running rqmonitor using this modification without any noticeable issues at the moment.

pranavgupta1234 commented 4 years ago

Hi @trodery
Thanks for noticing this issue. I do not see any issue with upgrading to python:3.8-slim. I will do a quick check and update the dockerfile as well as image to use python:3.8-slim

pranavgupta1234 commented 4 years ago

Updated.