search

pranaygp / vscode-css-peek

A vscode extension for peeking at CSS definitions from a class or id tag in HTML
MIT License
146 stars 32 forks source link

Brackets Includes Tags #10

Closed jercle closed 6 years ago

jercle commented 7 years ago

Brackets gives you the option to peek definitions for tags as well as the classes.

Is this possible for this extension?

pranaygp commented 7 years ago

Currently, this only works for class names and ids. It would be awesome to mimic the functionality of brackets better to make it also do tags, though I never got around to it :/

Would definitely be useful to have

jercle commented 7 years ago

I'm pretty new, but will see if I can figure it out. Bare in mind it would be my first ever pull request if I manage to figure it out though haha.

I'll have a play with it today. I love this extension, the only thing I'm missing from Brackets is that part of the peek. Cheers for letting me know it's not currently a feature! :)

pranaygp commented 6 years ago

An update:

I am in the middle of a rewrite of the codebase for this extension (making use of the new Language Server Protocol).

When releasing the new version (2.0) after this rewrite, I'll also make sure it supports normal HTML tag selectors (but won't support fancier things like [data-key="value"] ).

I'm keeping this issue open till it gets implemented and version 2.0 is out

pranaygp commented 6 years ago

Version 2.0 is out now and I added support for HTML tags. Brackets allows you to find a definition from both, the opening and closing HTML tags, but I'm limiting this to only the opening tags since that just seems to make more sense.

I'm happy to extend it to allow triggering the definition lookup from the closing tag too if people want that