pranaygp / vscode-css-peek

A vscode extension for peeking at CSS definitions from a class or id tag in HTML
MIT License
142 stars 32 forks source link

Support virtual workspaces #108

Open lszomoru opened 3 years ago

lszomoru commented 3 years ago

👋 Hi there, Martin here, from the VS Code team.

Recently we've announced the Remote Repository feature that lets you browse and edit files and folders directly on GitHub.

Open Remote Repository... opens VSCode on a folder or workspace located on a virtual file system. We call this a virtual workspace. We observed that not all extension support this well, either because they can not, or they haven't thought about it.

It would be fantastic if you could test whether your extension can handle virtual workspaces:

Check out the Virtual Workspaces Extension Author Guide on how to do that.

When done, set the new virtualWorkspaces capability in your 'package.json'.

{
  "capabilities": {
    "virtualWorkspaces": true | false
  }
}

For questions and comments please use the Virtual Workspaces Tracking Issue.

Thanks for the support and the great work! ❤️

pranaygp commented 1 year ago

right now there are 2 places in the code that that relies on the fs module. This code can easily be refactored to use the vscode fs API instead - which would allow the extension to work with Remote Repository.

I've tentatively marked that position in the code with a TODO and set the virtualWorkspace capability to false for now

pranaygp commented 1 year ago

(Any PR to fix this reliance on unnecessary fs is welcome)