Open isidorn opened 2 years ago
Hi @pranaygp! I was wondering if you might have thoughts on this? We're happy to discuss if you have any questions or feedback. Thank you!
Hey, sorry, I've been extremely busy at work.
If it's just a single line, are you able to make that PR for me please? I can merge and publish to the marketplace when I age a few minutes next week
--- original message --- On March 8, 2022, 4:17 PM PST @.*** wrote:
Hi @pranaygp! I was wondering if you might have thoughts on this? We're happy to discuss if you have any questions or feedback. Thank you!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***> --- end of original message ---
Thanks for the response @pranaygp!
I checked out your extension and this might be as simple as adding a browser property to your package.json that has the same value as the main property.
@isidorn based on this, do you think we just need to add: "browser": "./dist/web/extension.js",
?
I've enabled the "browser" flag in package.json as requested @isidorn (v4.3.5). Will test to see that it works as expected
@isidorn I'm unable to test this on vscode.dev currently because the extension has been marked as deprecated. Can you please revert that decision ASAP
We have reverted the deprecation of your extension. It is no longer deprecated. It might take an hour or two for this to get propagated in the UI.
:wave: I'm Isidor, a PM from the VS Code team, and we recently announced VS Code for the Web at https://vscode.dev/, which provides a free, zero-install Microsoft Visual Studio Code experience running entirely in your browser. You can learn more here.
We'd like to ensure css-peak can run in the web, and we have a guide for enabling extensions for the web here. As a couple of highlights:
browser
propertyvscode.workspace.fs
I checked out your extension and this might be as simple as adding a
browser
property to yourpackage.json
that has the same value as themain
property. Would you be open for a PR that fixes this?Please let us know if you have questions or feedback on enabling your extension for the web - our team would love to learn from your experiences and collaborate. Thank you!