search

pranaygp / vscode-css-peek

A vscode extension for peeking at CSS definitions from a class or id tag in HTML
MIT License
146 stars 32 forks source link

Initial JSX support for class attributes added #49

Closed RayMcCl closed 5 years ago

RayMcCl commented 5 years ago

The below set of changes adds simple support for JSX peek through the same mechanism that is already present. This is related to the below issue:

https://github.com/pranaygp/vscode-css-peek/issues/3

pranaygp commented 5 years ago

Can we add test files (a .js and .jsx) that have one of the test classes and/or ids here https://github.com/pranaygp/vscode-css-peek/tree/master/client/test/test_files. You can see the .html files making references to the classes and ids listed in the .css and .scss files.

These files aren't tested by the test suite (yet). They just exist so you can test the extension's behaviour manually.

RayMcCl commented 5 years ago

JS and JSX files have been added which follow the same structure as the existing HTML test.

pranaygp commented 5 years ago

@ReiMcCl seems like you're not using className in any of the examples. Could you update atleast one of them to use className and then we can ship this 👌

RayMcCl commented 5 years ago

Added className to the example js and jsx file 👍

pranaygp commented 5 years ago

Thanks!

pranaygp commented 5 years ago

Shipped in version 2.2.0