search

pranaygp / vscode-css-peek

A vscode extension for peeking at CSS definitions from a class or id tag in HTML
MIT License
145 stars 32 forks source link

Upgrade to new "rootPath" API #70

Closed pranaygp closed 4 years ago

pranaygp commented 4 years ago

I received this in the mail

Hello!

I am a developer on the VS Code team at Microsoft. If you are receiving this email, then you are the owner of a VS Code extension that appears to be using the vscode.workspace.rootPath API. This is a deprecated property and may not work as expected. I am reaching out to encourage you to upgrade your extension to properly support multi-root workspaces by switching to vscode.workspace.workspaceFolders instead.

Find more info about supporting multi-root workspaces here: https://github.com/microsoft/vscode/wiki/Adopting-Multi-Root-Workspace-APIs#eliminating-rootpath

And more details about this issue here: https://github.com/microsoft/vscode/issues/69335

Thanks!

This should be a straightforward migration. I'd love to collaborate on a PR for this since I have little time these days

akosasante commented 4 years ago

👋 I'd be interested in taking a look at this; though from a quick search, I don't currently see where this is being used apart from a single test?

pranaygp commented 4 years ago

yup, looks like it's just in the test @akosasante

really simple fix I believe

pranaygp commented 4 years ago

Yup, Fixed