search

pranaygp / vscode-css-peek

A vscode extension for peeking at CSS definitions from a class or id tag in HTML
MIT License
145 stars 32 forks source link

Support for Blade files #72

Closed MarcinKilarski closed 4 years ago

MarcinKilarski commented 4 years ago

Hi,

Unfortunately, your extension does not work on in files that end with .blade.php, which are Blade files. We use Blade templating engine to write all PHP code.

It works just fine if we change the file extension to .php, without any code changes inside the file.

I have tried adding blade.php, blade and .php file extensions to the list of vscode language names where the extension should be used in the extension settings. Unfortunately, it didn't work. Is it possible to make your extension work with Blade files?

It would make our life much easier.

pranaygp commented 4 years ago

Can you try setting the language mode on that VSCode file to php? My guess is vscode sets it to blade or something else instead of php, but if the extension is just .php, it'll set it to php.

If that works for you, it'll be a really easy fix on the extension since we'll just need to add "blade" to an array somewhere and it'll make for a really easy PR I can accept 😉

On Mon, Dec 2, 2019, 12:11 PM Martin Kilarski notifications@github.com wrote:

Hi,

Unfortunately, your extension does not work on in files that end with .blade.php, which are Blade https://laravel.com/docs/5.8/blade files. We use Blade templating engine to write all PHP code.

It works just fine if we change the file extension to .php, without any code changes inside the file.

I have tried adding blade.php, blade and .php file extensions to the list of vscode language names where the extension should be used in the extension settings. Unfortunately, it didn't work. Is it possible to make your extension work with Blade files?

It would make our life much easier.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pranaygp/vscode-css-peek/issues/72?email_source=notifications&email_token=AANW5NCJYHSODYP7VA73CRDQWVTYNA5CNFSM4JUFONLKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H5OGX2A, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANW5NDTIVEDKICSNTEJO5LQWVTYNANCNFSM4JUFONLA .

MarcinKilarski commented 4 years ago

Thanks for your quick reply.

I can confirm that setting the language mode on the VSCode file to PHP made your extension work just fine.

It would be great if you could add "blade" to an array.

I am looking forward to the next extension update :)

MarcinKilarski commented 4 years ago

Hi,

Could you tell me when do you plan to release the new version of the extension with this change?

pranaygp commented 4 years ago

It actually shouldn't need an update. Just add "blade" to your VSCode configuration for the "css_peek.peekFromLanguages" setting

MarcinKilarski commented 4 years ago

Sorry, I was not aware of this setting. I have added the blade to "css_peek.peekFromLanguages" setting and everything works fine. Thank you.

However, I would consider adding a blade to the default list of languages, because it is something between PHP and HTML.

Thanks again :)