search

praneeth-rdy / CV-Buddy

Build your CV in a very easy and simple way by using the templates provided in this project. As of now, it has CV templates of colleges IITKGP, IITM and IITB. New templates will be added on the way.
https://praneeth-rdy.github.io/CV-Buddy/
GNU General Public License v3.0
25 stars 23 forks source link

image adding feature added in IIT kgp template #10

Closed Gaurav05082002 closed 1 year ago

Gaurav05082002 commented 1 year ago

Fixes #

Proposed Changes

to @praneeth-rdy Regards gaurav

praneeth-rdy commented 1 year ago

Hi @Gaurav05082002

Can you remove the animation on the text "Click on profile to change it"? It seems too flashy.

The rest looks good to me. Thanks for the PR.

Best Regards, Praneeth

Gaurav05082002 commented 1 year ago

I have given that animation for attracting attention to this instruction, as we are not giving any edit btn/notice near the profile pic. so how a user will know that by clicking it , he/she can change it, simply written notice may be ignored by the user that's why I animated it, I thought this way.

once you read this mail, give me final confirmation to remove the animation from it, I will remove it. : )

On Tue, Jun 27, 2023 at 3:12 PM Praneeth Reddy Kolanu < @.***> wrote:

Hi @Gaurav05082002 https://github.com/Gaurav05082002

Can you remove the animation on the text "Click on profile to change it"? It seems too flashy.

The rest looks good to me. Thanks for the PR.

Best Regards, Praneeth

— Reply to this email directly, view it on GitHub https://github.com/praneeth-rdy/CV-Buddy/pull/10#issuecomment-1609151016, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATJQTC5UKEHEP35N3T466S3XNKTH7ANCNFSM6AAAAAAZT7CS5E . You are receiving this because you were mentioned.Message ID: @.***>

--

Gaurav Patidar

Tech Team Head | Spring Fest |

Indian Institute Of Technology, Kharagpur

+917689816680

@. @.>*

https://www.linkedin.com/in/gaurav-patidar-809997207/

praneeth-rdy commented 1 year ago

Got your point but the first written statement on the page is this instruction. I don't think one would ignore that. Also, the animation looks different from the simpler theme of the site. So, I'd still suggest to remove the animation for now.

Also, change the placeholder image to a dummy one instead of a real image of a person. Sample: https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcRVM9evfKqxhXvNhGi9F50DoiDJ14vGd3dnJg&usqp=CAU

Best Regards, @praneeth-rdy

Gaurav05082002 commented 1 year ago

okay , done regards

On Tue, Jun 27, 2023 at 6:53 PM Praneeth Reddy Kolanu < @.***> wrote:

Got your point but the first written statement on the page is this instruction. I don't think one would ignore that. Also, the animation looks different from the simpler theme of the site.

Also, change the placeholder image to a dummy one instead of a real image of a person. Sample:

https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcRVM9evfKqxhXvNhGi9F50DoiDJ14vGd3dnJg&usqp=CAU

Best Regards, @praneeth-rdy https://github.com/praneeth-rdy

— Reply to this email directly, view it on GitHub https://github.com/praneeth-rdy/CV-Buddy/pull/10#issuecomment-1609500269, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATJQTC655K2YVEJYCSZMJTLXNLNFPANCNFSM6AAAAAAZT7CS5E . You are receiving this because you were mentioned.Message ID: @.***>

--

Gaurav Patidar

Tech Team Head | Spring Fest |

Indian Institute Of Technology, Kharagpur

+917689816680

@. @.>*

https://www.linkedin.com/in/gaurav-patidar-809997207/