search

pranjal-joshi / Screeni-py

A Python-based stock screener to find stocks with potential breakout probability from NSE India.
MIT License
578 stars 205 forks source link

[Bug] Incorrect logic for the "weak down" trend in screener.py:findTrend #173

Closed danboyle7 closed 1 year ago

danboyle7 commented 1 year ago

Describe the bug There is the findTrend logic error in screening.py.

Under the findTrend function, the logic that labels the trend as "weak down" is incorrect. Currently, it is: elif (angle >= -30 and angle < -61):

However, this case is impossible. It should be: elif (angle <= -30 and angle > -61):

To Reproduce Steps to reproduce the behavior:

  1. Run screenipy on stock with a "weak down" slope below -30 and above -61.

Expected behavior The screener to correctly classify a trend with an angle between -30 and -61.

pranjal-joshi commented 1 year ago

Thanks for reporting the bug @danboyle7 Will be fixing this in the next release!

github-actions[bot] commented 1 year ago

This Issue is marked as Stale due to Inactivity. This Issue will be Closed soon.

pranjal-joshi commented 1 year ago

@danboyle7 Fixed in c30b982