pranjal-joshi / Screeni-py

A Python-based stock screener to find stocks with potential breakout probability from NSE India.
MIT License
552 stars 195 forks source link

added makefile #229

Closed soodrohit closed 7 months ago

soodrohit commented 8 months ago

added makefile for docker actions

pranjal-joshi commented 8 months ago

Hi @soodrohit

Can you explain how the makefile is getting used and what's the exact purpose?

soodrohit commented 8 months ago

Hi Pranjal,

The makefile is a automation tool for build management, since you have dockerized your project, so this is a faster way of getting the docker running, as an alternative of doing the same on Docker Dashboard as per your setup video.

One can simply run the make commands to achieve the same. E.g.

if you run the following command on your directory,

make run this will start the docker container with the specified port in the background, so that your command line is not blocked

make rebuild this will be useful, as one goes about making code changes and would like to build and start again..

Hope this helps.. ~Rohit

On Sun, 31 Dec 2023 at 00:01, Pranjal Joshi @.***> wrote:

Hi @soodrohit https://github.com/soodrohit

Can you explain how the makefile is getting used and what's the exact purpose?

— Reply to this email directly, view it on GitHub https://github.com/pranjal-joshi/Screeni-py/pull/229#issuecomment-1872671606, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDNDKXHXX2AZ6Q4G3BGW4LYMDWTZAVCNFSM6AAAAABBHWWJG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZSGY3TCNRQGY . You are receiving this because you were mentioned.Message ID: @.***>

github-actions[bot] commented 8 months ago

This PR is marked as Stale due to Inactivity.

pranjal-joshi commented 7 months ago

Hi @soodrohit

Is it possible for you to move this PR to new-features branch? The new feature test and CI-CD is attached to that branch! Consider opening a new PR on that branch if it can't be moved

soodrohit commented 7 months ago

Hi @soodrohit

Is it possible for you to move this PR to new-features branch? The new feature test and CI-CD is attached to that branch! Consider opening a new PR on that branch if it can't be moved

@pranjal-joshi sure.. will move it there