search

pranomostro / ratox

[wip] fifo based tox client
http://ratox.2f30.org/
ISC License
20 stars 2 forks source link

Add groupchat support #13

Closed jhert0 closed 7 years ago

iphydf commented 7 years ago

Note that in toktok/toxcore, group chats are called "conversation" and follow the rest of the API conventions, i.e. use error enum pointers and namespaced names (e.g. tox_del_groupchat is now tox_conversation_delete).

aaannndddyyy commented 7 years ago

Why such an unintuitive name? Why not something that conveys the idea that it is normally not just 1:1, but a group? Group, group chat, and conference come to my mind

iphydf commented 7 years ago

Sorry, I was actually wrong. It's conference.

aaannndddyyy commented 7 years ago

Ah, ok. Conference is fine. So this was just a typo, I guess. Is that rename in order to make a later transition to new group chats easier, or will old and new exists side by side, or is it general, that old and new will be called conference? Sorry, just curious.

iphydf commented 7 years ago

New group chats will be called "group". We chose these names, because old group chats are not persistent (i.e. when you leave, the conference is over until you are invited again), and require you to be friends with the inviter, so they are better suited for something like "conferences". Groups are more like IRC channels or other types of groups where you can join and leave at will and you don't need to know anyone in it.

aaannndddyyy commented 7 years ago

sounds reasonable. so old ones, now called conferences, will not go away, after new groups arrive?

iphydf commented 7 years ago

Indeed. The reason is that new group chats are currently a regression wrt. old group chats, in that they don't support TCP. I have a new-group-chats branch that I am keeping up to date with master, and I want it to be as close to master as possible, so I want it to support both group chat implementations. Clients could also implement both APIs and perhaps we'll eventually have both in master until new group chats are proven in use as reliable and feature-complete.

pranomostro commented 7 years ago

Groupchat support is on the TODO-list. However, I first think that making file transfer and audio chat perfect and reliable before I add this.

z3bra commented 7 years ago

Here we are then :)

pranomostro commented 7 years ago

Just merged rudimentary conferences (supporting text-chat, leaving, joining, inviting and changing the title).

Audio comes when the API seems stable enough.

aaannndddyyy commented 7 years ago

Thanks. :)