Is this code SAC-V not a SAC?

pranz24 / pytorch-soft-actor-critic

PyTorch implementation of soft actor critic

MIT License

810 stars 180 forks source link

Is this code SAC-V not a SAC? #43

Closed night2570 closed 8 months ago

night2570 commented 1 year ago

I thought this implementation was SAC rather than SAC-V. however, it seems like the agent does not contian ValueNetowrk, while the model.py include the ValuenNetwork. I am wondering this code of SAC-V and the value network is trace of previous implementation.

pranz24 commented 8 months ago

Yes. If you want you can send a pull request removing the ValueNetwork. (Doesn't really matter) (Very Sorry for the late reply.)