Closed prasadtalasila closed 6 years ago
Merging #164 into dev will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## dev #164 +/- ##
=======================================
Coverage 55.23% 55.23%
=======================================
Files 46 46
Lines 1260 1260
Branches 103 103
=======================================
Hits 696 696
Misses 541 541
Partials 23 23
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fafa9e7...54f568d. Read the comment docs.
@adityaketkar can you see any reason for the reduction in code coverage in this PR?
@prasadtalasila I think there is something wrong with codecov report. Please see the screenshot below :
After I going through the commit diff's, I am pretty sure that the src/main/* files are untouched by those commits. But still, the report suggests that lines were added to the branch. Is it possible to rerun the analysis?
@adityaketkar I rebased the tomcat8 branch with the dev branch. Now the codecov is showing a correct report. Please verify the same.
@raghavagrawal one unaddressed issue is the use of --prefix
. You said that you were facing problems. Can you please elaborate on the problems and give a log?
Updates the install scripts with the following improvements.
@raghavagrawal please review the changes proposed here.