Added Unit Tests for the SaveRepository Class

[kapilkalra04]

Description

• Added Unit Tests for the SaveRepositry Class which is present here
• Refactored the class to add new Autowired Fields to improve Dependency Injection
• Created SaveRepositoryConfig Class as well, to provide beans for the newly created Autowired fields in the concerned
• The beans provided in the SaveRepositoryConfig class were also added to ExperimentTestConfig (link)

Motivation

• Improves code coverage and testability of the code

  Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checks

• [x] Squash your commits down to one, or a few, discreet changesets before submitting a pull request
• [x] Read the contributing guide
• [x] PR should be motivated, i.e. what does it fix, why, and if relevant how
• [ ] If possible, include an example in the description, that could help all readers (including project members) to get a better picture of the change
• [x] Avoid other runtime dependencies unless abslutely necessary
• [x] Rebase your commit history so that each commit is meaningful and states the intention behind the change
• [x] Ensure that your pull request follows the style guidelines and coding standards
• [x] At least one commit should mention Fixes #<issue number> if relevant

Notify reviewers

@prasadtalasila

[codecov[bot]]

Codecov Report

Merging #176 into dev will increase coverage by 1.85%. The diff coverage is 45.71%.

@@            Coverage Diff             @@
##              dev     #176      +/-   ##
==========================================
+ Coverage   57.57%   59.43%   +1.85%     
==========================================
  Files          47       48       +1     
  Lines        1261     1267       +6     
  Branches      103      103              
==========================================
+ Hits          726      753      +27     
+ Misses        512      487      -25     
- Partials       23       27       +4

Impacted Files	Coverage Δ
...r/persistence/repository/SaveRepositoryConfig.java	0% <0%> (ø)
...nalyzer/persistence/repository/SaveRepository.java	87.75% <80%> (+51.54%)	:arrow_up:
...rotocolanalyzer/analyzer/network/IPv4Analyzer.java	94.87% <0%> (-1.29%)	:arrow_down:
...tocolanalyzer/analyzer/event/BucketLimitEvent.java	75% <0%> (+75%)	:arrow_up:
...tocolanalyzer/analyzer/event/SaveRepoEndEvent.java	75% <0%> (+75%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c7c8f50...2578889. Read the comment docs.

[prasadtalasila]

@kapilkalra04 please resolve the. Codeclimate issues.

[prasadtalasila]

@kapilkalra04 please fix the code climate issues.

[prasadtalasila]

@adityaketkar please complete the review of this PR at the earliest. Thanks.

[adityaketkar]

@kapilkalra04 the coverage for SaveRepository.java is almost complete with the latest commit, but shouldn't the tests cover SaveRepositoryConfig.java? Also, there is a minor codeclimate issue that needs to be addressed.

[prasadtalasila]

@adityaketkar and @kapilkalra04 There is no need to write tests for config classes. The ElasticSearchConfig was different. For the usual spring config classes, we don't need tests.

[kapilkalra04]

Regarding the code-climate issue, it's wrongly showing up and hence it was decided to ignore that 1 issue.