prasadtalasila / IRCLogParser

Parsing and analysis of IRC logs

GNU General Public License v3.0

15 stars 13 forks source link

nickTracker: modify unit test and add integration test #296

Closed Kausam closed 6 years ago

Kausam commented 6 years ago

What? Why?

Fix #282 . (Add Reference to the issue if any)

Changes proposed in this pull request:

a Add integration test for lib.nickTracker.nick_tracker() function
b Update unit tests for lib.nickTracker module
c Move common test data files of user module from test/data/user_test to test/data/test_lib/test_analysis/user_test

Checks

[X] Single commit and No merge commits
[ ] Make sure you have added required documentation
[ ] If you have refactored a code, make sure that you have compared the outputs pre and post refactoring. Add both pre and post refaoring screenshots below if the output is visual

Any images?

Notify reviewers

@kaushik-rohit @prasadtalasila

codecov[bot] commented 6 years ago

Codecov Report

Merging #296 into dev will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##             dev    #296   +/-   ##
=====================================
  Coverage   97.8%   97.8%           
=====================================
  Files         15      15           
  Lines       2230    2230           
=====================================
  Hits        2181    2181           
  Misses        49      49

Impacted Files	Coverage Δ
lib/nickTracker.py	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9fde6cb...35df3b9. Read the comment docs.

coveralls commented 6 years ago

Coverage remained the same at 35.471% when pulling 35df3b9eacbe1796f252ec7d20623fb42c8d7432 on Kausam:nickTracker into 9fde6cbbd9ba9b3f2a02636f29294932a4282cdf on prasadtalasila:dev.