prasadtalasila / IRCLogParser

Parsing and analysis of IRC logs

GNU General Public License v3.0

15 stars 13 forks source link

User Tracking #302

Closed Kausam closed 6 years ago

Kausam commented 6 years ago

What? Why?

Fix #298 . (Add Reference to the issue if any)

Changes proposed in this pull request:

add functional test for user tracking

Checks

[ ] Single commit and No merge commits
[ ] Make sure you have added required documentation
[ ] If you have refactored a code, make sure that you have compared the outputs pre and post refactoring. Add both pre and post refaoring screenshots below if the output is visual

Any images?

Notify reviewers

@kaushik-rohit @prasadtalasila

codecov[bot] commented 6 years ago

Codecov Report

Merging #302 into dev will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #302   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files          15       15           
  Lines        2230     2230           
=======================================
  Hits         2180     2180           
  Misses         50       50

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 711aa54...3fc40fc. Read the comment docs.

coveralls commented 6 years ago

Coverage increased (+2.6%) to 38.072% when pulling 3fc40fca43b284ac1a4910e04788f269019f077b on Kausam:dev into 711aa5474401d3acc66c7b9902e5a509b7caba4f on prasadtalasila:dev.

kaushik-rohit commented 6 years ago

@prasadtalasila @Kausam The PR looks good to me. Only one thing, some of the tests are already there in test_functional.py and might need to be removed.

prasadtalasila commented 6 years ago

@Kausam you are partially correct on having HITS test in user tracking. As per the paper, Fig 11 (page 19), TF-IDF vs HITS comparison is part of user profile.