prasadtalasila / IRCLogParser

Parsing and analysis of IRC logs

GNU General Public License v3.0

15 stars 13 forks source link

Functional test for networks module #316

Closed bhuvangupta008 closed 6 years ago

bhuvangupta008 commented 6 years ago

What? Why?

Fix #311 . (Add Reference to the issue if any)

Changes proposed in this pull request:

a Adds functional test for networks module. (8 days of log data)

Checks

[ ] Single commit and No merge commits
[ ] Make sure you have added required documentation
[ ] If you have refactored a code, make sure that you have compared the outputs pre and post refactoring. Add both pre and post refaoring screenshots below if the output is visual

Any images?

Notify reviewers

@kaushik-rohit @prasadtalasila

codecov[bot] commented 6 years ago

Codecov Report

Merging #316 into dev will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #316   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files          15       15           
  Lines        2230     2230           
=======================================
  Hits         2180     2180           
  Misses         50       50

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c7cf090...bbc2662. Read the comment docs.

coveralls commented 6 years ago

Coverage increased (+0.5%) to 62.287% when pulling bbc266230bc89810b9b027b14bce4690192bce08 on bhuvangupta008:network-functional into c7cf090920dda86f84dca25fd53d5c93035cad7c on prasadtalasila:dev.