prasadtalasila / IRCLogParser

Parsing and analysis of IRC logs

GNU General Public License v3.0

14 stars 13 forks source link

Use calendar library to find a month's end date #321

Closed Kausam closed 6 years ago

Kausam commented 6 years ago

What? Why?

Fix #320 .

Changes proposed in this pull request:

use python's calendar library to find a month's end date

Checks

[ ] Single commit and No merge commits
[ ] Make sure you have added required documentation
[ ] If you have refactored a code, make sure that you have compared the outputs pre and post refactoring. Add both pre and post refaoring screenshots below if the output is visual

Any images?

Notify reviewers

@kaushik-rohit @prasadtalasila

codecov[bot] commented 6 years ago

Codecov Report

Merging #321 into dev will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #321   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files          15       15           
  Lines        2230     2230           
=======================================
  Hits         2180     2180           
  Misses         50       50

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 57ff7f3...8a546e2. Read the comment docs.

coveralls commented 6 years ago

Coverage remained the same at 59.148% when pulling 8a546e2368b84adf220c2aa30c479b9483bdc48e on Kausam:refactMonthIterator into 57ff7f3862c7baf27a4e0663f6a1670d0dc41b4f on prasadtalasila:dev.

prasadtalasila commented 6 years ago

The changes proposed in this PR have been included in PR #322.