Closed bhuvangupta008 closed 6 years ago
Merging #335 into dev will increase coverage by
0.06%
. The diff coverage is100%
.
@@ Coverage Diff @@
## dev #335 +/- ##
==========================================
+ Coverage 97.48% 97.54% +0.06%
==========================================
Files 17 21 +4
Lines 2265 2323 +58
==========================================
+ Hits 2208 2266 +58
Misses 57 57
Flag | Coverage Δ | |
---|---|---|
#functional | 56.65% <0%> (-1.46%) |
:arrow_down: |
#integration | 59.62% <0%> (-1.53%) |
:arrow_down: |
#unit | 97.41% <100%> (+0.06%) |
:arrow_up: |
Impacted Files | Coverage Δ | |
---|---|---|
lib/in_out/parser/slack.py | 100% <100%> (ø) |
|
lib/in_out/parser/parser.py | 100% <100%> (ø) |
|
lib/in_out/parser/scummvm.py | 100% <100%> (ø) |
|
lib/in_out/parser/ubuntu.py | 100% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3e0991e...63d9d25. Read the comment docs.
@bhuvangupta008 do you want to update this PR as the work on parser progresses? If not, please close this PR.
@bhuvangupta008 The PR requires few more additions and changes in order to be reviewed again. Thanks.
@prasadtalasila sir, I didn't understand what additions and changes are you refering to. If you're refering to unittests please refer to my message on the slack channel, post which i shall continue writing the tests.
@prasadtalasila added the unittests
@prasadtalasila @kaushik-rohit separated the channel into multiple modules
Thanks @bhuvangupta008 . The PR has been merged.
What? Why?
Fix #335 . (Add Reference to the issue if any)
Changes proposed in this pull request:
Testing(briefly mention the tests you wrote in regard to the proposed changes)
Checks
Any images?
Notify reviewers
@kaushik-rohit @prasadtalasila