search

prasanak / tipcalculator

Tip Calculator App.
0 stars 0 forks source link

[intro to ios1] prework - review my app #1

Open prasanak opened 9 years ago

prasanak commented 9 years ago

Hi,

My app is complete, please review. /cc @codepathreview.

Thanks, Prasanna

timothy1ee commented 9 years ago

Prasanna, thanks for your submission. You're missing a requirement which was to add a Settings page. Also, you shouldn't be calling release in your project, you should be using ARC.

When you fix those things, can you comment here?

prasanak commented 9 years ago

Thanks Tim. I'll implement the setting page.

On Wed, Jan 21, 2015 at 11:24 PM, Timothy Lee notifications@github.com wrote:

Prasanna, thanks for your submission. You're missing a requirement which was to add a Settings page. Also, you shouldn't be calling release in your project, you should be using ARC.

When you fix those things, can you comment here?

— Reply to this email directly or view it on GitHub https://github.com/prasanak/tipcalculator/issues/1#issuecomment-70981109 .