Fix build on OpenBSD within mozilla : snappy-c.h:49: error: comma at end of enumerator list

[GoogleCodeExporter]

Trying to build mozilla-central on OpenBSD, it fails because of an erroneous 
comma at end of snappy_status enum.

Full build line/options :

c++ -o snappy-c.o -c -I../../dist/stl_wrappers -I../../dist/system_wrappers 
-include 
/var/buildslave-mozilla/mozilla-central-amd64/build/config/gcc_hidden.h 
-DMOZ_GLUE_IN_PROGRAM -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API 
-DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET 
-DIMPL_THEBES  -DSTATIC_EXPORTABLE_JS_API  
-I/var/buildslave-mozilla/mozilla-central-amd64/build/other-licenses/snappy -I. 
-I../../dist/include -I../../dist/include/nsprpub  
-I/usr/obj/buildslave-m-c/dist/include/nspr 
-I/usr/obj/buildslave-m-c/dist/include/nss      -fPIC -I/usr/X11R6/include 
-fno-rtti -pedantic -Wall -Wpointer-arith -Woverloaded-virtual 
-Werror=return-type -Wno-ctor-dtor-privacy -Wno-overlength-strings 
-Wno-invalid-offsetof -Wno-variadic-macros -Wcast-align -Wno-long-long 
-fno-exceptions -fno-strict-aliasing -fshort-wchar -ffunction-sections 
-fdata-sections -pthread -pipe  -DNDEBUG -DTRIMMED -g -O -fomit-frame-pointer  
-I/usr/X11R6/include -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MF 
.deps/snappy-c.pp 
/var/buildslave-mozilla/mozilla-central-amd64/build/other-licenses/snappy/src/sn
appy-c.cc
In file included from 
/var/buildslave-mozilla/mozilla-central-amd64/build/other-licenses/snappy/src/sn
appy-c.cc:30:
/var/buildslave-mozilla/mozilla-central-amd64/build/other-licenses/snappy/src/sn
appy-c.h:49: error: comma at end of enumerator list
gmake[5]: *** [snappy-c.o] Error 1

Removing the comma fixes it :

 typedef enum {
   SNAPPY_OK = 0,
   SNAPPY_INVALID_INPUT = 1,
-  SNAPPY_BUFFER_TOO_SMALL = 2,
+  SNAPPY_BUFFER_TOO_SMALL = 2
 } snappy_status;

Downstream bug report : https://bugzilla.mozilla.org/show_bug.cgi?id=755663

Original issue reported on code.google.com by landry.b...@gmail.com on 16 May 2012 at 12:25

[GoogleCodeExporter]

Patch

Original comment by Ms2...@gmail.com on 19 May 2012 at 8:58

Attachments:

• x

[GoogleCodeExporter]

Original comment by se...@google.com on 21 May 2012 at 10:19

• Changed state: Accepted

[GoogleCodeExporter]

Fixed in r63.

Original comment by se...@google.com on 22 May 2012 at 9:46

• Changed state: Fixed

[GoogleCodeExporter]

Thanks, much appreciated.

Original comment by Ms2...@gmail.com on 22 May 2012 at 11:05