search

prasannap5 / snappy

Automatically exported from code.google.com/p/snappy
Other
0 stars 0 forks source link

Unused function ComputeTable() in snappy.cc #96

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
snappy.cc has a function ComputeTable() that's not called anywhere. Comments 
suggest that it's supposed to be called when snappy_dump_decompression_table is 
set (to verify that char_table is correct), but that's not currently done.

This is causing -Wunused-function warnings.

Original issue reported on code.google.com by thakis@chromium.org on 28 Jul 2015 at 3:47

GoogleCodeExporter commented 9 years ago

Original comment by thakis@chromium.org on 28 Jul 2015 at 10:30

GoogleCodeExporter commented 9 years ago 
What do you suggest we do? Having the function here obviously is useful for 
documentation; otherwise the table is just way too magical. In Google, there's 
a module initializer that checks that the table actually is correct, but we 
don't have module initializers readily available outside that.

We could put #if 0 around these in the opensource version?

Original comment by se...@google.com on 7 Aug 2015 at 3:12