prasanthrangan / hyprdots

// Aesthetic, dynamic and minimal dots for Arch hyprland
GNU General Public License v3.0
7.64k stars 894 forks source link

[Feature Request]: Add support for wezterm #1452

Closed rubiin closed 1 month ago

rubiin commented 6 months ago

Feature Request

Description

wezterm is a great terminal and has many themes and fonts inbuilt . Adding support for wezterm similar to kitty should be doable.

[Provide a clear and concise description of the feature you'd like to see added.]

Use Case

[Describe how this feature would be useful to you or to other users of the project.]

Proposed Solution

[If you have a specific solution in mind, describe it here. If not, you can skip this section.]

Alternatives

[Are there any alternative solutions or workarounds that you've considered? If so, describe them here.]

Additional Information

[Add any other information about the feature request here. For example, you might include links to similar features in other projects, or screenshots or diagrams to help explain your idea.]

noahfraiture commented 6 months ago

What is the use case ? What are the pros and cons compared to kitty which is already well implemented in the whole project

kRHYME7 commented 6 months ago

I can't render wezterm

rubiin commented 6 months ago

The pro being , all the configs being in lua and neovim also uses lua , its easy. While kitty configs are plain configs, wezterm uses lua so you could add runtime conditions . Also its a gpu accelerated terminal faster and has all the fonts, themes baked in

cassiofb-dev commented 6 months ago

I can't render wezterm

@kRHYME7 yeah, something broke recently and I had to fallback to xwayland for making it work:

if os.getenv("XDG_CURRENT_DESKTOP") == "Hyprland" then
    config.enable_wayland = false
else
    config.enable_wayland = true
end

And I also like wezterm more.

rubiin commented 6 months ago

heres my wezterm config https://github.com/rubiin/dotfiles/blob/master/private_dot_config/wezterm/wezterm.lua#L67

rubiin commented 6 months ago

I can't render wezterm

@kRHYME7 yeah, something broke recently and I had to fallback to xwayland for making it work:

if os.getenv("XDG_CURRENT_DESKTOP") == "Hyprland" then
  config.enable_wayland = false
else
  config.enable_wayland = true
end

And I also like wezterm more.

This is no longer needed if you use wezterm-git. This was fixed

kRHYME7 commented 6 months ago

image image

rubiin commented 6 months ago

https://github.com/rubiin/dotfiles/tree/master/private_dot_config/wezterm can you try with this settings. Omit the fonts

rubiin commented 6 months ago

you can try

I can't render wezterm

@kRHYME7 yeah, something broke recently and I had to fallback to xwayland for making it work:

if os.getenv("XDG_CURRENT_DESKTOP") == "Hyprland" then
    config.enable_wayland = false
else
    config.enable_wayland = true
end

And I also like wezterm more.

This is no longer needed if you use wezterm-git. This was fixed

you can try this as last resort

asilvam133 commented 4 months ago

wezterm-git works as expected. @kRHYME7 for the, the main advantage of using Wezterm instead of Kitty is better support for monospace characters, particularly when italic are enabled.

This is Wezterm image

This is Kitty image

Additionally, most of the themes that you find for Kitty are available for Wezterm as well.

Here is my config just to show how to separate themes from configuration https://github.com/asilvam133/.wezterm.

kRHYME7 commented 4 months ago

so this happened

image

And ncurses will try to do it on other device

asilvam133 commented 4 months ago

Oh that happened to me as well because I had wezterm installed before. What I did was uninstall wezterm, install wezterm-git, then the error shows up, then try install it again, and it worked. I don't remember if I had to delete that folder, but you could give it a try to see if it works.

asilvam133 commented 4 months ago

Oh that happened to me as well because I had wezterm installed before. What I did was uninstall wezterm, install wezterm-git, then the error shows up, then try install it again, and it worked. I don't remember if I had to delete that folder, but you could give it a try to see if it works.

@kRHYME7 To expand/correct on this, I got an error because I had wezterm installed, but it's the same error that you are getting with ncurses. You probably don't wish to uninstall it, and there's a workaround for this one https://github.com/wez/wezterm/issues/5464#issuecomment-2131354269

rubiin commented 2 months ago

if anyone has problems with fastfetch not rendering image on wez, try this on your zshrc


if [ "$TERM" = "wezterm" ]; then
    alias fastfetch='fastfetch --logo-type kitty-direct --logo-height 18 --logo-width 34'
fi
rubiin commented 2 months ago

you might need to adjust the size image

kRHYME7 commented 2 months ago

So how can I launch wezterm hahaha

image

Okay Wow for the first time it works ahahHAHA image image

rubiin commented 2 months ago

I use wezterm-git , works well

rubiin commented 2 months ago

image

kRHYME7 commented 2 months ago

how to remove this one? image

rubiin commented 2 months ago

I think thats a bug on the latest commit. That doesnt seem to affect anything , ignore for now :D

kRHYME7 commented 2 months ago

Haha here :

sudo nvim /etc/profile.d/wezterm.sh

edit line 491

image

PS1="$__wezterm_save_ps1"

BTW is it easy to theme with walbash?

rubiin commented 2 months ago

Yes. Wezterm has many themes and fonts inbuilt.

kRHYME7 commented 2 months ago

Cool, wil be expecting a PR then

rubiin commented 2 months ago

I am working on something just a poc. Problem is some themes are not available, will have to map them to closest looking theme thats on wezterm default

kRHYME7 commented 2 months ago

hmmm I guess we can make it simple. Check how they implemented the pywal

abenezerw commented 2 months ago

Haha of course it’s Rubiin with the wezterm 😂. Doing some spring cleaning and saw your PR. Wezterm doesn’t have a colorscheme.lua? I prefer kitty but. would be nice to support all terminals too huh.

kRHYME7 commented 1 month ago

Yow I manage to do it. Please do a PR to make the README.md better. Or better to link it to the site. (I'm clueless how to do it 😭)

https://github.com/HyDE-Project/terminals-hyde/tree/main/wezterm

Sidenotes:

kRHYME7 commented 1 month ago

I will be closing this here for now.