prasanthrangan / hyprdots

// Aesthetic, dynamic and minimal dots for Arch hyprland
GNU General Public License v3.0
6.83k stars 814 forks source link

[Feature Request]: Is there any plans of using ags #1645

Open chrollorifat opened 3 months ago

NotAF0e commented 2 months ago

This would be wonderful +1

kRHYME7 commented 2 months ago

Hey how about sharing a working ags config then will do it in wallbash. How bout that?

chrollorifat commented 2 months ago

Hey how about sharing a working ags config then will do it in wallbash. How bout that?

Here, you can check out this repo: https://github.com/Jas-SinghFSU/HyprPanel

kRHYME7 commented 2 months ago

Cool. But this would become a breaking change in the repo.

  1. How about I will fork the above repo and try maintaining it.

Then we can have Hyde-panel which at first becomes an installer and should populate Hyprpanel to ~/.config/hydepanel

This should work as a separate package and configuration without touching ./ags folder.

I'm not sure If I can pull it off but the main goal of forking it is to make sure certain files will be placed correctly.

  1. You guys can disregard 1. The best approach for me is to just help you make a wallbash template for this. I think this one is easy. Then the panels should be DIY. This way we have lesser issues and obligations on this repo.
sitolam commented 1 month ago

Cool. But this would become a breaking change in the repo.

1. How about  I will fork the above repo and try  maintaining it.

Then we can have Hyde-panel which at first becomes an installer and should populate Hyprpanel to ~/.config/hydepanel

This should work as a separate package and configuration without touching ./ags folder.

I'm not sure If I can pull it off but the main goal of forking it is to make sure certain files will be placed correctly.

2. You guys can disregard 1.
   The best approach for me is to just help you make a wallbash template for this. I think this one is easy. Then the panels should be DIY. This way we have lesser issues and obligations on this repo.

I like option 1 😃

kRHYME7 commented 1 month ago

Hyprpanel Lags when I toggle something 😭

dotaxis commented 3 weeks ago
   The best approach for me is to just help you make a wallbash template for this. I think this one is easy. Then the panels should be DIY. This way we have lesser issues and obligations on this repo.

I would greatly appreciate this if you still have any interest :)

kRHYME7 commented 3 weeks ago

For option 2

We need to know where the Hyprpanel gets it's colors. Is it hardcoded? follows GTK? can we declare it in a single file?.

dotaxis commented 3 weeks ago

There is a themes folder in the repo filled with JSON files that contain the colours for each theme.

I don't actually use AGS yet so I'm not sure if that's actually what you're asking.

kRHYME7 commented 3 weeks ago

This?

https://github.com/Jas-SinghFSU/HyprPanel/blob/master/scss/style/colors.scss

Jas-SinghFSU commented 3 weeks ago

HyprPanel dev here, will provide more info tomorrow. Also, what toggle are causing you to lag?

kRHYME7 commented 3 weeks ago

HyprPanel dev here, will provide more info tomorrow.

Wow! Hi, it will be easy to integrate Hyprpanel if there is an existing pywal template (Which I think there is ). The script use to generate colors only need the target file and we can make a template for the target file. I guess ags can update CSS dynmically right?

Also, what toggle are causing you to lag?

All the buttons here makes the cursors laggy. But I guess this can be fix later on image Edit: popups like notification also tends to lag. : So I observed that it only lags on my main monitor with x2 scaling. On my external monitor it works pretty well.

Some disclaimer, I'm no owner of this repo therefore I can't guarantee and confident to merge more features on this repo. What I can do though is adding some patches so we can at least integrate something to his repo without changing it fundamentally.

We can dedicate a wiki or some sort of howto page ( to extend this repo's functionality) for Hyprpanel and also other external rices .

sitolam commented 2 weeks ago

How can I test this?

kRHYME7 commented 2 weeks ago

@Jas-SinghFSU Will definitely open an issue soon. But theming hyprpanel is so easy. You guys did the "themeable" part very well.

Using ags -r "useTheme('${cacheDir}/landing/hyprpanel_wallbash.json')"

image image

Jas-SinghFSU commented 2 weeks ago

WTF, that's so sick!

kRHYME7 commented 2 weeks ago

WTF, that's so sick!

It's because of your implementation making it easy to integrate.

  1. is there a way to store hyprpanel configs from a different directory without linking it?

example ags -c ~/.config/HyprPanel/config.js (This works ) but importing in the GUI reverts it back to ~/.config/ags

  1. IIRC, ags can follow the gtk theme right? Is this possible now over hyprpanel?
Jas-SinghFSU commented 2 weeks ago

I haven't looked in to #.2 at yet. Most of theming I've done so far has been manual.

As for #.1 you're saying that importing a config in the gui restarts the bar without the specified config directory?

kRHYME7 commented 2 weeks ago
  1. Yes It forgets about the initial -c path I gave.

  2. I've tried to finish the tutorial for ags and that time I did not do theming at all, it follows the gtk by default.

Jas-SinghFSU commented 2 weeks ago

I'll have to look at default gtk theme some other time but I can provide a way to specify a restart config in the useTheme method if that would help

kRHYME7 commented 2 weeks ago

useTheme method if that would help

Thank you! Also, Will definitely open an issue in your repo.