ShinniUwU commented 2 months ago

Pull Request

Description

This pull request introduces improvements to the Flatpak installation script by adding user interaction features, such as a selection menu and confirmation prompts. These enhancements aim to provide a more user-friendly experience during the installation of Flatpak applications.

Summary of Changes

Added an interactive menu to allow users to select specific Flatpak applications or install all at once.
Implemented a confirmation prompt to review choices before proceeding with the installation.
Added error handling for cases where the application list is empty or invalid.
Included setup commands to ensure Flatpak applications have access to GTK themes and icons.

Motivation and Context

The previous script lacked user interaction and always installed all applications listed in the configuration file. The new script allows for more control over the installation process, making it more flexible and user-friendly.

Dependencies

No new dependencies are introduced. The script relies on existing functions from global_fn.sh, specifically pkg_installed.

Related Issues

N/A

Type of change

Please put an x in the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (non-breaking change; modified files are limited to the documentation)
[ ] Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
[ ] Other (provide details below)

Checklist

Please put an x in the boxes that apply:

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[x] My commit message follows the commit guidelines.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added a changelog entry.
[x] I have added necessary comments/documentation to my code.
[ ] I have added tests to cover my changes.
[ ] I have tested my code locally and it works as expected.
[ ] All new and existing tests passed.

Screenshots

N/A

Additional context

kRHYME7 commented 2 months ago

@rubiin Have you tried running the script?

rubiin commented 2 months ago

Nah I just verified the code visually

prasanthrangan / hyprdots

fix: improve Flatpak installation script for better user interaction … #1793