search

prasanthrangan / hyprdots

// Aesthetic, dynamic and minimal dots for Arch hyprland
GNU General Public License v3.0
7.74k stars 903 forks source link

Battery Notify Spam #424

Closed slowayy closed 1 year ago

slowayy commented 1 year ago

Every 20-30s the battery_notify.sh ping's once time saying "battery is full, please disconnect the charger!" the laptop is always docked. was supposed to be 300s idk why this is happen, i installed this rice today, and i see who has an PR merged by @kRHYME7 i guess you can help with this!

i disabled the script in hyprland.conf for dont ping anymore Using a laptop

T-Crypt commented 1 year ago

@oxzh -- I disabled mine cause I keep my laptop docked.

slowayy commented 1 year ago

me too

kRHYME7 commented 1 year ago

Yup my latest PR fixes this.

kRHYME7 commented 1 year ago

Just being dumb dumb of me and naive. Sorry for not expecting to have these conditions, Ill update soon. But I needed inputs for the user huhu. #420

What do you think about making all defaults null like if no flags means null thus not notifying it? Or adding docking mode which disables all notifications. It would be very helpful if we could discuss this in PR #420. Thank You. I owe you guys a lot

image

slowayy commented 1 year ago

sorry but i cant help, i new into linux and shell scripts so

kRHYME7 commented 1 year ago

It's Fine! We all are learning things here. How about sharing your preferred use cases for this battery notification utility. So that I can make defaults for the General?

slowayy commented 1 year ago

would be good, if 20% battery, warns for connect power supply, 50% too for, like, warning, and 5% suspends the notebook, for not losing any works or smth

kRHYME7 commented 1 year ago

Thanks how about disabling the Battery full notification by default?

kRHYME7 commented 1 year ago

or Adding docking mode to disable just the battery full notif but still has this

would be good, if 20% battery, warns for connect power supply, 50% too for, like, warning, and 5% suspends the notebook, for not losing any works or smth

slowayy commented 1 year ago

have a way to notify ONCE time, when it reaches 100%? i think is better than being notified every x seconds

slowayy commented 1 year ago

and a possible solution

kRHYME7 commented 1 year ago

Oh nice that would be easier

kRHYME7 commented 1 year ago

Hi Are you willing to test this?

kRHYME7 commented 1 year ago

Defaults:

image

slowayy commented 1 year ago

Hi Are you willing to test this?

yes, if still need

kRHYME7 commented 1 year ago

Can you try to pull the latest commit on my PR #420 ?

slowayy commented 1 year ago

@kRHYME7 its working normaly for me, im going to close after you response, i see you last pr, has been merge so, i guess is normal now

kRHYME7 commented 1 year ago

Thanks for your help