prasathmani / tinyfilemanager

Single-file PHP file manager, browser and manage your files efficiently and easily with tinyfilemanager
https://tinyfilemanager.github.io
GNU General Public License v3.0
4.61k stars 1.63k forks source link

Added Feature to Display Disk Space Usage #1100

Open hppanpaliya opened 8 months ago

hppanpaliya commented 8 months ago
Screenshot 2023-10-17 at 7 29 49 PM Screenshot 2023-10-17 at 7 30 19 PM

Changes:

Benefits:

Use Case:

Screenshots:

Example with Mounted disk:

Screenshot 2023-10-17 at 7 30 12 PM Screenshot 2023-10-17 at 7 29 29 PM

I believe this feature, along with the toggle setting, would be a valuable addition to Tiny File Manager, helping users better manage their disk space on servers with multiple drives. I have tested the changes on my local setup to ensure accuracy and compatibility. Looking forward to the feedback and am happy to make any necessary adjustments.

Thank you for considering this contribution.

acastrovargas commented 5 months ago

Congratulations

ner00 commented 5 months ago

This PR reminds me of PR https://github.com/prasathmani/tinyfilemanager/pull/911, albeit this one is more elegant and complete, but I never really understood why the latter wasn't merged back then. I did end up implementing it in my custom version though since I think it's undeniable that it adds to the script without taking anything away.

image

hppanpaliya commented 5 months ago

Thank you for referencing PR #911. My PR aims to provide a detailed view of disk usage for systems with multiple mounted drives. Unlike #911, which shows disk space for the root directory, this enhancement displays the disk space for each mounted drive, including external ones. This is particularly useful when drives are mounted as folders, ensuring users can monitor the disk space of these specific directories(drives) accurately. I've attached images from both PRs for clarity, showing the functionality in both the root directory and an external drive context.

Screenshot Screenshot Screenshot Screenshot
ner00 commented 5 months ago

Thanks for clarifying this, I wasn't fully aware of the extension of your implementation (although I admittedly hadn't read your entire description yet). I hope this gets merged soon, but even if it doesn't I'll look into integrating it within my custom script anyway.

ririko5834 commented 1 week ago

will this be merged? it looks good