prasathmani / tinyfilemanager

Single-file PHP file manager, browser and manage your files efficiently and easily with tinyfilemanager
https://tinyfilemanager.github.io
GNU General Public License v3.0
4.87k stars 1.66k forks source link

Sorting arrows are not there #1184

Open anderewrey opened 4 months ago

anderewrey commented 4 months ago

I'm on version 2.5.3 and maybe it is a local config problem, but the sorting arrows on filename/size/date columns are not displayed (and so, not possible to sort). I have that problem on both my laptop browser and on my smartphone browser.

While I can see these arrows on the demo, they are not visible on my hosted site.

Screenshot_2024-05-20-21-41-33-90_3aea4af51f236e4932235fdada7d1643

Screenshot_2024-05-20-21-40-59-10_3aea4af51f236e4932235fdada7d1643

Any idea how to investigate the problem?

Thanks

prasathmani commented 4 months ago

not sure, arrow icons are loading from css

anderewrey commented 4 months ago

so the icon is embedded and associated to css style over the header. I will start there. Thanks.

From your knowledge, nothing should prevent that sorting ability, right?

prasathmani commented 4 months ago

yes

anderewrey commented 4 months ago

Found the error, and your master branch is no more affected because you're now fetching the assets on the web directly.

But in v2.5.3: https://github.com/prasathmani/tinyfilemanager/releases/tag/2.5.3 https://github.com/prasathmani/tinyfilemanager/blob/2.5.3/tinyfilemanager.php#L149

    'js-jquery-datatables' => '<script src="assets/js/dataTables.min.js"></script>',

and on Linux, the path is case-sensitive: https://github.com/prasathmani/tinyfilemanager/blob/2.5.3/assets/js/datatables.min.js

see the capital 'T' in dataTable.

Since the real file has capital 'T' :

    'js-jquery-datatables' => '<script src="https://cdn.datatables.net/1.13.1/js/jquery.dataTables.min.js" crossorigin="anonymous" defer></script>',

It means the problem happened when you copied the file in the assert folder.