prasenjeet-symon / intellectia

Intellectia - Your Guardian Against Misleading AI-Generated Content
MIT License
15 stars 45 forks source link

Bug Fixes for apiRequestGETUserFollowingsSuggestSizeValidator in Validators Tests #218

Closed prasenjeet-symon closed 9 months ago

prasenjeet-symon commented 10 months ago

Title: Bug Fixes for apiRequestGETUserFollowingsSuggestSizeValidator in Validators Tests

Description: This GitHub issue aims to resolve the identified bugs in the validators.test.ts file, specifically within the apiRequestGETUserFollowingsSuggestSizeValidator describe block. The bugs in these tests are causing failures and need to be addressed to ensure the accuracy and reliability of the tests.

Tasks:

  1. Test Analysis:

    • [ ] Re-run the tests in the validators.test.ts file, focusing on the apiRequestGETUserFollowingsSuggestSizeValidator describe block.
    • [ ] Carefully review the test failures, error messages, and stack traces to understand the nature of the bugs.
  2. Bug Identification:

    • [ ] Identify and document the specific bugs or issues within the apiRequestGETUserFollowingsSuggestSizeValidator test cases.
  3. Bug Fixes:

    • [ ] Implement fixes for the identified bugs in the test cases.
    • [ ] Ensure that test assertions, logic, and expected values are corrected to accurately reflect the intended behavior.
  4. Test Validation:

    • [ ] Re-run the tests in the validators.test.ts file, especially those within the apiRequestGETUserFollowingsSuggestSizeValidator describe block, to confirm that the bug fixes have resolved the issues.
  5. Documentation:

    • [ ] Update the test documentation to reflect the bug fixes and provide clarity on the corrected test cases.

Acceptance Criteria:

Additional Information:

Once the bug fixes are made and the tests pass, you can proceed to create this GitHub issue in your repository for further tracking and resolution.

Milcke commented 10 months ago

@prasenjeet-symon hey mate, can I get added to this one please? Cheers!

Milcke commented 10 months ago

@prasenjeet-symon - Express route for this one just needed to be rearranged as the paths were too similar. I am wondering if this will cause issues in the future?

The routes must go in this order: "/server/api/user/followings/suggest/:size" then "/server/api/user/followings/:size/:cursor"

If you are happy I can push the changes and get this closed.

prasenjeet-symon commented 10 months ago

@prasenjeet-symon - Express route for this one just needed to be rearranged as the paths were too similar. I am wondering if this will cause issues in the future?

The routes must go in this order: "/server/api/user/followings/suggest/:size" then "/server/api/user/followings/:size/:cursor"

If you are happy I can push the changes and get this closed.

Seems correct

Milcke commented 10 months ago

Pull request sent - let me know if any issues persist.

Cheers!