search

prash-wghats / Electron-VSCode-Atom-For-FreeBSD

Electron, VSCode, Atom & LightTable port for FreeBSD
96 stars 11 forks source link

Atom/VSCode build scripts that use system Electron? #10

Closed yzgyyang closed 6 years ago

yzgyyang commented 6 years ago

My WIP Electron port () now installs Electron to /usr/local/lib/electron/* and create symlink to /usr/local/bin/electron (executable). Starting from here, can applications based on Electron (Atom, VSCode, ...) directly or indirectly use this?

prash-wghats commented 6 years ago

@yzgyyang. It should be possible. Although most of the Electron Apps comes with its own copy of electron. Main issue here is that the Apps should be compatible with the installed electron version. For example the latest Atom is using electron version 1.7. Though it doesn't mean that it will not work with electron 1.8. Should check with a Electron app expert.

yzgyyang commented 6 years ago

https://github.com/electron/electron/pull/12426 PR merged and will be in future Electron releases!